Skip to content

Improve reliability of cloned request cleanup #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2025
Merged

Improve reliability of cloned request cleanup #693

merged 1 commit into from
Apr 13, 2025

Conversation

sholladay
Copy link
Collaborator

Fixes #690

Prevents requests from hanging in certain cases by

  1. Waiting until all retries are complete before cleaning up the final retry clone, rather than cleaning up each retry clone after each retry.
  2. Cleaning up the retry clone even if there is an error.

@sholladay sholladay merged commit 1f903ed into sindresorhus:main Apr 13, 2025
1 check passed
@sholladay sholladay deleted the delay-cleanup branch April 13, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ky 1.8.0 hang
1 participant
@sholladay