Skip to content

OTLP-4278 Update Kubernetes example to latest version #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2021

Conversation

shree007
Copy link
Contributor

@shree007 shree007 commented Nov 1, 2021

Description:
The k8s example here has old otel collector image which does not had the new tls config implementation so replacing with new one and command line flag --mem-ballast-size-mib has been deprecated so removed that flag as well.

Link to tracking Issue:
4247

Testing:
I performed following steps in minikube k8s
$ kubectl apply -f otel-config.yaml

$ kubectl get pod

and checked all pod were up and there were no TLS error

Documentation:
Once it gets merged I will update the docs.

@shree007 shree007 requested review from a team and jpkrohling November 1, 2021 16:11
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #4329 (0517737) into main (c0e8f31) will increase coverage by 1.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4329      +/-   ##
==========================================
+ Coverage   88.07%   89.57%   +1.49%     
==========================================
  Files         173      176       +3     
  Lines       10188    10376     +188     
==========================================
+ Hits         8973     9294     +321     
+ Misses        975      844     -131     
+ Partials      240      238       -2     
Impacted Files Coverage Δ
service/zpages.go 79.38% <0.00%> (-0.82%) ⬇️
config/config.go 100.00% <0.00%> (ø)
config/exporter.go 88.88% <0.00%> (ø)
config/receiver.go 88.88% <0.00%> (ø)
config/extension.go 88.88% <0.00%> (ø)
config/processor.go 88.88% <0.00%> (ø)
config/configgrpc/configgrpc.go 93.91% <0.00%> (ø)
model/pdata/generated_common.go 100.00% <0.00%> (ø)
model/pdata/generated_resource.go 100.00% <0.00%> (ø)
exporter/exporterhelper/factory.go 100.00% <0.00%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e8f31...0517737. Read the comment docs.

@shree007
Copy link
Contributor Author

shree007 commented Nov 1, 2021

/easycla

@codeboten
Copy link
Contributor

Looks like the CLA check is failing, does this PR superseed #4278?

@shree007
Copy link
Contributor Author

shree007 commented Nov 2, 2021

Looks like the CLA check is failing, does this PR superseed #4278?

@codeboten yes Easycla is not working, i filed one support ticket for that.
I have tested with 0.38.0 and it's working i fine.
I have replaced previous image tag with 0.38.0 as you commented and resolved the conversation.
Yes #4278 would be suppressed.

@codeboten
Copy link
Contributor

/easycla

1 similar comment
@nickmango
Copy link

/easycla

@jpkrohling
Copy link
Member

@nickmango, do you have news about the EasyCLA check?

@nickmango
Copy link

/easycla

@WillsonHG
Copy link

this is a troubleshooting comment /easycla

@WillsonHG
Copy link

/easycla

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 9, 2021

CLA Signed

The committers are authorized under a signed CLA.

@wanyaland
Copy link

@nickmango, do you have news about the EasyCLA check?

@jpkrohling yes this has been fixed

@jpkrohling
Copy link
Member

/easycla

@jpkrohling
Copy link
Member

@shree007, looks like there's a missing piece to your local git configuration :-) Look at the link provided in an earlier comment by the EasyCLA integration.

@shree007
Copy link
Contributor Author

@shree007, looks like there's a missing piece to your local git configuration :-) Look at the link provided in an earlier comment by the EasyCLA integration.

@jpkrohling checking from my end.

@shree007
Copy link
Contributor Author

@shree007, looks like there's a missing piece to your local git configuration :-) Look at the link provided in an earlier comment by the EasyCLA integration.

@jpkrohling checking from my end.

@jpkrohling Looks like Easycla has been resolved, I need your approval here, please have a look.

@bogdandrutu
Copy link
Member

@shree007 yaay, thanks a tone for all the effort.

@bogdandrutu bogdandrutu merged commit da9dff0 into open-telemetry:main Nov 10, 2021
@shree007
Copy link
Contributor Author

Thanks @jpkrohling @bogdandrutu @wanyaland for all the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants