-
Notifications
You must be signed in to change notification settings - Fork 1.7k
OTLP-4278 Update Kubernetes example to latest version #4329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4329 +/- ##
==========================================
+ Coverage 88.07% 89.57% +1.49%
==========================================
Files 173 176 +3
Lines 10188 10376 +188
==========================================
+ Hits 8973 9294 +321
+ Misses 975 844 -131
+ Partials 240 238 -2
Continue to review full report at Codecov.
|
/easycla |
Looks like the CLA check is failing, does this PR superseed #4278? |
@codeboten yes Easycla is not working, i filed one support ticket for that. |
/easycla |
1 similar comment
/easycla |
@nickmango, do you have news about the EasyCLA check? |
/easycla |
this is a troubleshooting comment /easycla |
/easycla |
@jpkrohling yes this has been fixed |
/easycla |
@shree007, looks like there's a missing piece to your local git configuration :-) Look at the link provided in an earlier comment by the EasyCLA integration. |
@jpkrohling checking from my end. |
d8f525c
to
5ae5d8e
Compare
@jpkrohling Looks like Easycla has been resolved, I need your approval here, please have a look. |
@shree007 yaay, thanks a tone for all the effort. |
Thanks @jpkrohling @bogdandrutu @wanyaland for all the help. |
Description:
The k8s example here has old otel collector image which does not had the new tls config implementation so replacing with new one and command line flag --mem-ballast-size-mib has been deprecated so removed that flag as well.
Link to tracking Issue:
4247
Testing:
I performed following steps in minikube k8s
$ kubectl apply -f otel-config.yaml
$ kubectl get pod
and checked all pod were up and there were no TLS error
Documentation:
Once it gets merged I will update the docs.